sinpro.dev
Docs
Dev Environment
ChatGPT Prompts
  • Company Information
    • Portfolio
    • About
    • Services
    • Events
  • Dev Environment
    • macOS Settings
    • Chrome Extensions
    • VSCode Workspace Settings
    • VSCode Workspace Extensions
    • Global NPM Packages
    • npm-check-updates
    • SvelteKit
    • Customize Zsh
    • ChatGPT Prompts
    • Tailwind CSS
    • Warp
    • Keyboard Shortcuts
  • Assets
    • Assets
    • JPG/PNG to AVIF
    • TTF to WOFF2
  • Clean Code
    • Clean Code
    • Format
    • Quality
    • Variables
    • Functions
    • Objects and Data Structures
    • Classes
    • Concurrency
    • Error handling
    • Comments
  • Code Style
    • TypeScript Config
    • Prettier
    • ESLint
    • Stylelint
  • Testing
    • Vitest
    • Playwright
  • Git
    • Git Branches and Commits
    • Git Hooks
    • Git User Profiles
    • Git for Windows
  • GitHub
    • GitHub Issues
    • GitHub Pull Requests
    • GitHub Repository Settings
    • GitHub Branch Protection
    • GitHub Actions
  • Code Quality
    • SonarCloud Coverage
  • Server
    • SSH
    • PM2
    • Caddy
    • Updating the server
    • ngrok
  • Team sinProject
    • Our Team Policy
    • Equipment and Supplies
    • Books
    • Slack
    • Locales
    • Funny Apps
    • Docs History
  • Talk
    • Talk
    • Creating a Project
    • App Structure

GitHub

GitHub Pull Requests

Edit this page

On completing an issues, we create a pull request (PR).

Pull Request Template

In the template, write tasks for the following:

  • For the Submitter
    • Tasks
  • For the Reviewer
    • Before Reviewing
    • Checks
    • After Reviewing

View this file

Title

  • Format
Markdown
<Issue Title> #<Issue Number>
  • Example
Markdown
Show scrollbar like Mac #942

Reviewers

Assign the person in charge of reviewing.

PR review and praise what was good about it.

Labels

If it’s related to an enhancement, add the ‘enhancement’ label.

If it involves a significant change, add the ‘breaking-change’ label.

Merge pull request

Select the method to create a merge commit.

Do not select ‘Squash and merge’ or ‘Rebase and merge’.

If you want to use these, please inform me of their benefits before doing so. I will consider the policy.

GitHub Issues GitHub Repository Settings
© sinProject. v0.73.0
On this page
  • GitHub Pull Requests
  • Pull Request Template
  • Title
  • Reviewers
  • Labels
  • Merge pull request